[Mesa-dev] [PATCH] mesa: need to check resource and set length even if bufSize is 0

[Ilia Mirkin]

Hi Tapani,

Looks like you added this function (and the logic I'm removing) in
commit 2ab8de218 (mesa: implementation of glGetProgramResourceiv).
Could you have a look at this change and see if it makes sense to you?

Thanks,

  -ilia

On Fri, Feb 12, 2016 at 12:19 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> This fixes a number of dEQP tests, such as:
>
> dEQP-GLES31.functional.program_interface_query.buffer_limited_query.resource_query
>
> It was expecting the length to be set even in the bufSize == 0 case.
> Also _mesa_get_program_resourceiv does some error checking on the
> resource which should probably happen even in the bufSize == 0 case as
> well although there's no dEQP test for that.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/mesa/main/program_resource.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c
> index 50659b0..0d9f8ae 100644
> --- a/src/mesa/main/program_resource.c
> +++ b/src/mesa/main/program_resource.c
> @@ -357,10 +357,6 @@ _mesa_GetProgramResourceiv(GLuint program, GLenum programInterface,
>        return;
>     }
>
> -   /* No need to write any properties, user requested none. */
> -   if (bufSize == 0)
> -      return;
> -
>     _mesa_get_program_resourceiv(shProg, programInterface, index,
>                                  propCount, props, bufSize, length, params);
>  }
> --
> 2.4.10
>