[Mesa-dev] [PATCH 1/2] glsl: remove unused helper

Iago Toral itoral at igalia.com
Mon Feb 15 14:45:13 UTC 2016


Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

On Mon, 2016-02-15 at 18:38 +1100, Timothy Arceri wrote:
> Seems to have become unused when i965 moved to NIR.
> ---
>  src/compiler/glsl/ir.cpp | 15 ---------------
>  src/compiler/glsl/ir.h   | 11 -----------
>  2 files changed, 26 deletions(-)
> 
> diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/ir.cpp
> index c7a2496..750f617 100644
> --- a/src/compiler/glsl/ir.cpp
> +++ b/src/compiler/glsl/ir.cpp
> @@ -1696,21 +1696,6 @@ interpolation_string(unsigned interpolation)
>     return "";
>  }
>  
> -
> -glsl_interp_qualifier
> -ir_variable::determine_interpolation_mode(bool flat_shade)
> -{
> -   if (this->data.interpolation != INTERP_QUALIFIER_NONE)
> -      return (glsl_interp_qualifier) this->data.interpolation;
> -   int location = this->data.location;
> -   bool is_gl_Color =
> -      location == VARYING_SLOT_COL0 || location == VARYING_SLOT_COL1;
> -   if (flat_shade && is_gl_Color)
> -      return INTERP_QUALIFIER_FLAT;
> -   else
> -      return INTERP_QUALIFIER_SMOOTH;
> -}
> -
>  const char *const ir_variable::warn_extension_table[] = {
>     "",
>     "GL_ARB_shader_stencil_export",
> diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h
> index bf9b7ca..93c893d 100644
> --- a/src/compiler/glsl/ir.h
> +++ b/src/compiler/glsl/ir.h
> @@ -432,17 +432,6 @@ public:
>  
> 
>     /**
> -    * Determine how this variable should be interpolated based on its
> -    * interpolation qualifier (if present), whether it is gl_Color or
> -    * gl_SecondaryColor, and whether flatshading is enabled in the current GL
> -    * state.
> -    *
> -    * The return value will always be either INTERP_QUALIFIER_SMOOTH,
> -    * INTERP_QUALIFIER_NOPERSPECTIVE, or INTERP_QUALIFIER_FLAT.
> -    */
> -   glsl_interp_qualifier determine_interpolation_mode(bool flat_shade);
> -
> -   /**
>      * Determine whether or not a variable is part of a uniform or
>      * shader storage block.
>      */




More information about the mesa-dev mailing list