[Mesa-dev] [v2 16/19] i965: Expose logic telling if non-msrt mcs is supported

[Ben Widawsky]

On Thu, Feb 11, 2016 at 08:34:09PM +0200, Topi Pohjolainen wrote:
> Alos use the opportunity to mark inputs constant. (Context has to be

Also

> given as read-write to intel_miptree_supports_non_msrt_fast_clear()
> to support debug output).
> 
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 +++++----
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 ++++++++
>  2 files changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index a072268..6c233d8 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -161,8 +161,9 @@ intel_get_non_msrt_mcs_alignment(struct intel_mipmap_tree *mt,
>     }
>  }
>  
> -static bool
> -intel_tiling_supports_non_msrt_mcs(struct brw_context *brw, unsigned tiling)
> +bool
> +intel_tiling_supports_non_msrt_mcs(const struct brw_context *brw,
> +                                   unsigned tiling)
>  {
>     /* From the Ivy Bridge PRM, Vol2 Part1 11.7 "MCS Buffer for Render
>      * Target(s)", beneath the "Fast Color Clear" bullet (p326):
> @@ -200,9 +201,9 @@ intel_tiling_supports_non_msrt_mcs(struct brw_context *brw, unsigned tiling)
>   *     - MCS and Lossless compression is supported for TiledY/TileYs/TileYf
>   *     non-MSRTs only.
>   */
> -static bool
> +bool
>  intel_miptree_supports_non_msrt_fast_clear(struct brw_context *brw,
> -                                           struct intel_mipmap_tree *mt)
> +                                           const struct intel_mipmap_tree *mt)
>  {
>     /* MCS support does not exist prior to Gen7 */
>     if (brw->gen < 7)
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> index a21f33f..7cdfb37 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> @@ -671,6 +671,14 @@ intel_miptree_is_lossless_compressed(const struct brw_context *brw,
>                                       const struct intel_mipmap_tree *mt);
>  
>  bool
> +intel_tiling_supports_non_msrt_mcs(const struct brw_context *brw,
> +                                   unsigned tiling);
> +
> +bool
> +intel_miptree_supports_non_msrt_fast_clear(struct brw_context *brw,
> +                                           const struct intel_mipmap_tree *mt);
> +
> +bool
>  intel_miptree_alloc_non_msrt_mcs(struct brw_context *brw,
>                                   struct intel_mipmap_tree *mt);
>  
[snip]

With the "Also" fix in the commit message:
Reviewed-by: Ben Widawsky <benjamin.widawsky at intel.com>

-- 
Ben Widawsky, Intel Open Source Technology Center