[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

[Rob Clark]

On Wed, Feb 17, 2016 at 4:40 PM, Patrick Baggett
<baggett.patrick at gmail.com> wrote:
> On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark <robdclark at gmail.com> wrote:
>> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined but not used [-Wunused-function]
>>  lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir)
>>  ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> The base class method that was intended to be overridden was
>> 'visit(ir_loop_jump *ir)', not visit_entire().
>>
> Has there been a discussion about using the "override" keyword
> (C++11)? It sounds like it could catch bugs like this, and if hidden
> behind a #define, act as a no-op when C++11 is not supported. Although
> obviously the new gcc6 warning is effectively doing much the same
> thing...
>

tbh, I'm not sure what, if any, C++11 discussion has happened.. most
of the code I deal with is C

BR,
-R

>
>> Signed-off-by: Rob Clark <robdclark at gmail.com>
>> ---
>>  src/compiler/glsl/lower_discard_flow.cpp | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/compiler/glsl/lower_discard_flow.cpp b/src/compiler/glsl/lower_discard_flow.cpp
>> index 9d0a56b..9e3a7c0 100644
>> --- a/src/compiler/glsl/lower_discard_flow.cpp
>> +++ b/src/compiler/glsl/lower_discard_flow.cpp
>> @@ -62,8 +62,8 @@ public:
>>     {
>>     }
>>
>> +   ir_visitor_status visit(ir_loop_jump *ir);
>>     ir_visitor_status visit_enter(ir_discard *ir);
>> -   ir_visitor_status visit_enter(ir_loop_jump *ir);
>>     ir_visitor_status visit_enter(ir_loop *ir);
>>     ir_visitor_status visit_enter(ir_function_signature *ir);
>>
>> @@ -76,7 +76,7 @@ public:
>>  } /* anonymous namespace */
>>
>>  ir_visitor_status
>> -lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir)
>> +lower_discard_flow_visitor::visit(ir_loop_jump *ir)
>>  {
>>     if (ir->mode != ir_loop_jump::jump_continue)
>>        return visit_continue;
>> --
>> 2.5.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev