[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

Ian Romanick idr at freedesktop.org
Thu Feb 18 01:43:02 UTC 2016


I ran this through our CI, and I didn't see any regressions cause by it.
 I think this is correct, so this patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 02/17/2016 01:35 PM, Rob Clark wrote:
> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined but not used [-Wunused-function]
>  lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir)
>  ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> The base class method that was intended to be overridden was
> 'visit(ir_loop_jump *ir)', not visit_entire().
> 
> Signed-off-by: Rob Clark <robdclark at gmail.com>
> ---
>  src/compiler/glsl/lower_discard_flow.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/compiler/glsl/lower_discard_flow.cpp b/src/compiler/glsl/lower_discard_flow.cpp
> index 9d0a56b..9e3a7c0 100644
> --- a/src/compiler/glsl/lower_discard_flow.cpp
> +++ b/src/compiler/glsl/lower_discard_flow.cpp
> @@ -62,8 +62,8 @@ public:
>     {
>     }
>  
> +   ir_visitor_status visit(ir_loop_jump *ir);
>     ir_visitor_status visit_enter(ir_discard *ir);
> -   ir_visitor_status visit_enter(ir_loop_jump *ir);
>     ir_visitor_status visit_enter(ir_loop *ir);
>     ir_visitor_status visit_enter(ir_function_signature *ir);
>  
> @@ -76,7 +76,7 @@ public:
>  } /* anonymous namespace */
>  
>  ir_visitor_status
> -lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir)
> +lower_discard_flow_visitor::visit(ir_loop_jump *ir)
>  {
>     if (ir->mode != ir_loop_jump::jump_continue)
>        return visit_continue;
> 



More information about the mesa-dev mailing list