[Mesa-dev] [PATCH] st/mesa: fix pbo uploads

Roland Scheidegger sroland at vmware.com
Thu Feb 18 15:53:17 UTC 2016


Am 18.02.2016 um 16:34 schrieb Ilia Mirkin:
> On Feb 18, 2016 6:16 AM, "Marek Olšák" <maraeo at gmail.com
> <mailto:maraeo at gmail.com>> wrote:
>>
>> On Thu, Feb 18, 2016 at 7:07 AM, Ilia Mirkin <imirkin at alum.mit.edu
> <mailto:imirkin at alum.mit.edu>> wrote:
>> >  - LOD must be provided in .w for TXF (even for buffer textures)
>>
>> TXF on BUFFER should ignore the LOD.
> 
> No such exception in the docs. Nouveau expects it to be set to 0.
> 
>>
>> >  - User buffer must be valid at draw time
>> >  - Must have a sampler associated with the sampler view
>>
>> TXF doesn't use the sampler state.
> 
> I agree in principle. In practice, I got all black rendering without
> this. The alternative is reverting the pbo patches since they regress
> nouveau... This seemed like the more appealing solution.
> 

Well, if you do a texelFetch in GLSL GL would still consider the texture
incomplete depending on the sampler state - if the sampler state is
actually used or not doesn't matter (albeit not all drivers might agree).

Roland



More information about the mesa-dev mailing list