[Mesa-dev] [PATCH] llvmpipe: add a few const qualifiers

Roland Scheidegger sroland at vmware.com
Thu Feb 18 15:58:14 UTC 2016


Am 18.02.2016 um 16:52 schrieb Brian Paul:
> ---
>  src/gallium/drivers/llvmpipe/lp_setup_context.h | 4 ++--
>  src/gallium/drivers/llvmpipe/lp_setup_line.c    | 2 +-
>  src/gallium/drivers/llvmpipe/lp_setup_tri.c     | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_setup_context.h b/src/gallium/drivers/llvmpipe/lp_setup_context.h
> index 5ab297d..9714691 100644
> --- a/src/gallium/drivers/llvmpipe/lp_setup_context.h
> +++ b/src/gallium/drivers/llvmpipe/lp_setup_context.h
> @@ -169,8 +169,8 @@ struct lp_setup_context
>  };
>  
>  static inline void
> -scissor_planes_needed(boolean scis_planes[4], struct u_rect *bbox,
> -                      struct u_rect *scissor)
> +scissor_planes_needed(boolean scis_planes[4], const struct u_rect *bbox,
> +                      const struct u_rect *scissor)
>  {
>     /* left */
>     scis_planes[0] = (bbox->x0 < scissor->x0);
> diff --git a/src/gallium/drivers/llvmpipe/lp_setup_line.c b/src/gallium/drivers/llvmpipe/lp_setup_line.c
> index af4e790..018130c 100644
> --- a/src/gallium/drivers/llvmpipe/lp_setup_line.c
> +++ b/src/gallium/drivers/llvmpipe/lp_setup_line.c
> @@ -719,7 +719,7 @@ try_setup_line( struct lp_setup_context *setup,
>      */
>     if (nr_planes > 4) {
>        /* why not just use draw_regions */
> -      struct u_rect *scissor = &setup->scissors[viewport_index];
> +      const struct u_rect *scissor = &setup->scissors[viewport_index];
>        struct lp_rast_plane *plane_s = &plane[4];
>        boolean s_planes[4];
>        scissor_planes_needed(s_planes, &bbox, scissor);
> diff --git a/src/gallium/drivers/llvmpipe/lp_setup_tri.c b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> index cdb3d01..29aee72 100644
> --- a/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> +++ b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> @@ -681,7 +681,7 @@ do_triangle_ccw(struct lp_setup_context *setup,
>      */
>     if (nr_planes > 3) {
>        /* why not just use draw_regions */
> -      struct u_rect *scissor = &setup->scissors[viewport_index];
> +      const struct u_rect *scissor = &setup->scissors[viewport_index];
>        struct lp_rast_plane *plane_s = &plane[3];
>        boolean s_planes[4];
>        scissor_planes_needed(s_planes, &bbox, scissor);
> 

Reviewed-by: Roland Scheidegger <sroland at vmware.com>


More information about the mesa-dev mailing list