[Mesa-dev] [PATCH v2 4/4] Android: disable unused-parameter warning

[Emil Velikov]

Hi Rob,

On 2 February 2016 at 20:45, Rob Herring <robh at kernel.org> wrote:
> Android builds with -Wunused-parameter enabled which results in spewing
> lots of warnings. Disable it so more meaningful warnings are more visible.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
> v2:
> - No change
>
>  Android.common.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Android.common.mk b/Android.common.mk
> index 72fa5d9..c4823f7 100644
> --- a/Android.common.mk
> +++ b/Android.common.mk
> @@ -32,6 +32,7 @@ LOCAL_C_INCLUDES += \
>  MESA_VERSION := $(shell cat $(MESA_TOP)/VERSION)
>  # define ANDROID_VERSION (e.g., 4.0.x => 0x0400)
>  LOCAL_CFLAGS += \
> +       -Wno-unused-parameter \

Based of your earlier numbers, I'm leaning that we can resolve the 3
warnings and toggle this back on at some point ?

I've replied to some patches (add a comment or two for EGL_ANDROID_foo
patches 1, 2 and 5 && kill off/move -msse4.1) and picked everything
else. Please let me know if I missed something.

I'm seriously contemplating about picking all of your patches (B) for
stable. Must admit that I might be biased, although considering that
some of these have been in android-x86 for a couple of mesa releases I
think we're safe.

How do others feel on the topic ?

Thanks
Emil


(B)
 - add virt-gpu pci-ids
 - wire up the virgl + vtest to the android build
 - enable misc EGL_ANDROID extensions
 - misc build fixes (arm64, SSE4.1)