[Mesa-dev] [PATCH v2] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

[Emil Velikov]

On 16 February 2016 at 16:37, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi,
>
> On 16 February 2016 at 16:34, Derek Foreman <derekf at osg.samsung.com> wrote:
>> +try_damage_buffer(struct dri2_egl_surface *dri2_surf,
>> +                  const EGLint *rects,
>> +                  EGLint n_rects)
>> +{
>> +/* The WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION macro and
>> + * wl_proxy_get_version() were both introduced in wayland 1.10.
>> + * Instead of bumping our wayland dependency we just make this
>> + * function conditional on the required 1.10 features, falling
>> + * back to old (correct but suboptimal) behaviour for older
>> + * wayland.
>> + */
>> +#ifdef WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION
>
> It still bumps the runtime requirement, i.e. once built against >=1.10
> it can only ever be run against >= 1.10. Maybe dlsym is overkill, but
> OTOH maybe not ...
>
We have enough places in mesa which require build-time version <=
run-time version. If one is brave enough to go the opposite way, I'm
sorry but they get what they're asking for - a rainbow of issues ;-)

Distros tend to follow this so things should be fine imho.

Cheers,
Emil