[Mesa-dev] [PATCH 2/2] gallivm: Check whether to stop disassemble only for x86

[Roland Scheidegger]

Am 18.02.2016 um 17:23 schrieb Oded Gabbay:
> Because the if statement that checks whether we have a return
> statement is valid only on x86, surround it with X86 or X86-64
> arch defines
> 
> Signed-off-by: Oded Gabbay <oded.gabbay at gmail.com>
> ---
>  src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
> index 7e98f1a..efaf2fa 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
> @@ -200,9 +200,11 @@ disassemble(const void* func, std::stringstream &buffer)
>         * XXX: This currently assumes x86
>         */
>  
> +#if defined(PIPE_ARCH_X86) || defined(PIPE_ARCH_X86_64)
>        if (Size == 1 && bytes[pc] == 0xc3) {
>           break;
>        }
> +#endif
>  
>        /*
>         * Advance.
> 

My c++ is a bit weak but the series looks good to me too.
Reviewed-by: Roland Scheidegger <sroland at vmware.com>