[Mesa-dev] [PATCH v2 1/2] mesa: add GL_OES_texture_border_clamp support

[Ilia Mirkin]

On Feb 19, 2016 8:05 AM, "Samuel Iglesias Gonsálvez" <siglesias at igalia.com>
wrote:
>
> On Wed, Feb 17, 2016 at 08:46:36PM -0500, Ilia Mirkin wrote:
> > Only minor differences to the existing ARB_texture_border_clamp support.
> >
> > Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> > ---
> >
> > v1 -> v2: added a patch to add the EXT version of this extension
> >
> >  docs/GL3.txt                            |  2 +-
> >  src/mapi/glapi/gen/es_EXT.xml           | 58
++++++++++++++++++++++++++++++++-
> >  src/mesa/main/extensions_table.h        |  1 +
> >  src/mesa/main/samplerobj.c              |  6 ++--
> >  src/mesa/main/tests/dispatch_sanity.cpp | 10 ++++++
> >  src/mesa/main/texparam.c                | 11 ++++---
> >  6 files changed, 80 insertions(+), 8 deletions(-)
> >
> > diff --git a/docs/GL3.txt b/docs/GL3.txt
> > index ea7ceef..0957247 100644
> > --- a/docs/GL3.txt
> > +++ b/docs/GL3.txt
> > @@ -253,7 +253,7 @@ GLES3.2, GLSL ES 3.2
> >    GL_OES_shader_io_blocks                              not started
(based on parts of GLSL 1.50, which is done)
> >    GL_OES_shader_multisample_interpolation              not started
(based on parts of GL_ARB_gpu_shader5, which is done)
> >    GL_OES_tessellation_shader                           not started
(based on GL_ARB_tessellation_shader, which is done for some drivers)
> > -  GL_OES_texture_border_clamp                          not started
(based on GL_ARB_texture_border_clamp, which is done)
> > +  GL_OES_texture_border_clamp                          DONE (all
drivers)
> >    GL_OES_texture_buffer                                not started
(based on GL_ARB_texture_buffer_object, GL_ARB_texture_buffer_range, and
GL_ARB_texture_buffer_object_rgb32 that are all done)
> >    GL_OES_texture_cube_map_array                        not started
(based on GL_ARB_texture_cube_map_array, which is done for all drivers)
> >    GL_OES_texture_stencil8                              not started
(based on GL_ARB_texture_stencil8, which is done for some drivers)
> > diff --git a/src/mapi/glapi/gen/es_EXT.xml
b/src/mapi/glapi/gen/es_EXT.xml
> > index 86df980..fb0ef05 100644
> > --- a/src/mapi/glapi/gen/es_EXT.xml
> > +++ b/src/mapi/glapi/gen/es_EXT.xml
> > @@ -982,5 +982,61 @@
> >          <param name="texture" type="GLuint"/>
> >          <param name="level" type="GLint"/>
> >      </function>
> > -  </category>
> > +</category>
> > +
> > +<category name="GL_OES_texture_border_clamp" number="215">
> > +
> > +    <enum name="TEXTURE_BORDER_COLOR_OES" value ="0x1004"/>
> > +    <enum name="CLAMP_TO_BORDER_OES"      value="0x812D"/>
> > +
> > +    <function name="TexParameterIivOES" es2="3.0"
alias="TexParameterIiv">
>
> I have a doubt here that it is repeated along this patch and the
following one...
> Shouldn't it be es2="3.2"? Because the extension was in core in OpenGL ES
3.2.

That's not what this means... It might be core in gles 1000000, but the
entrypoint should be exposed in gles3. The ext itself is available starting
gles2, but int formats only became available in gles3, and this entrypoint
only applies to int color formats.

  -ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160219/f1e8cba5/attachment.html>