[Mesa-dev] [PATCH 8/9] mesa: updates some comments in buffers.c

Rob Clark robdclark at gmail.com
Wed Feb 24 00:53:21 UTC 2016


On Tue, Feb 23, 2016 at 6:45 PM, Brian Paul <brianp at vmware.com> wrote:
>

Reviewed-by: Rob Clark <robdclark at gmail.com>

> ---
>  src/mesa/main/buffers.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c
> index c400082..70c2a21 100644
> --- a/src/mesa/main/buffers.c
> +++ b/src/mesa/main/buffers.c
> @@ -551,8 +551,8 @@ updated_drawbuffers(struct gl_context *ctx, struct gl_framebuffer *fb)
>
>
>  /**
> - * Helper function to set the GL_DRAW_BUFFER state in the context and
> - * current FBO.  Called via glDrawBuffer(), glDrawBuffersARB()
> + * Helper function to set the GL_DRAW_BUFFER state for the given context and
> + * FBO.  Called via glDrawBuffer(), glDrawBuffersARB()
>   *
>   * All error checking will have been done prior to calling this function
>   * so nothing should go wrong at this point.
> @@ -668,8 +668,11 @@ _mesa_update_draw_buffers(struct gl_context *ctx)
>
>  /**
>   * Like \sa _mesa_drawbuffers(), this is a helper function for setting
> - * GL_READ_BUFFER state in the context and current FBO.
> + * GL_READ_BUFFER state for the given context and FBO.
> + * Note that all error checking should have been done before calling
> + * this function.
>   * \param ctx  the rendering context
> + * \param fb  the framebuffer object to update
>   * \param buffer  GL_FRONT, GL_BACK, GL_COLOR_ATTACHMENT0, etc.
>   * \param bufferIndex  the numerical index corresponding to 'buffer'
>   */
> --
> 1.9.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list