[Mesa-dev] [PATCH 6/8] freedreno: drop unnecessary -Wno-packed-bitfield-compat

Rob Clark robdclark at gmail.com
Wed Feb 24 19:11:03 UTC 2016


hmm, we did need this at one point in time for the packed structs used
for shader instruction assembly.. maybe newer gcc doesn't warn about
this (since it mostly seems related to a bug in older gcc versions)?
I guess since (afaiu) android provides it's own compiler per android
release, I suppose we don't have to worry about someone building w/
any random old gcc version, so I don't see any issue dropping this for
the android build.

On Wed, Feb 24, 2016 at 1:56 PM, Rob Herring <robh at kernel.org> wrote:
> Enabling this warning doesn't generate any warnings with gcc, but is an
> unknown option for clang, so drop it.
>
> Cc: Rob Clark <robdclark at gmail.com>
> Signed-off-by: Rob Herring <robh at kernel.org>

Acked-by: Rob Clark <robdclark at gmail.com>

> ---
>  src/gallium/drivers/freedreno/Android.mk | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/gallium/drivers/freedreno/Android.mk b/src/gallium/drivers/freedreno/Android.mk
> index 8c1ab08..cd46f39 100644
> --- a/src/gallium/drivers/freedreno/Android.mk
> +++ b/src/gallium/drivers/freedreno/Android.mk
> @@ -32,9 +32,6 @@ LOCAL_SRC_FILES := \
>         $(a4xx_SOURCES) \
>         $(ir3_SOURCES)
>
> -LOCAL_CFLAGS := \
> -       -Wno-packed-bitfield-compat
> -
>  LOCAL_C_INCLUDES := \
>         $(LOCAL_PATH)/ir3
>
> --
> 2.5.0
>


More information about the mesa-dev mailing list