[Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

[Oded Gabbay]

On Fri, Feb 26, 2016 at 5:03 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 26.02.2016 06:09, Oded Gabbay wrote:
>> After further testing, it appears there is no need for
>> separate BE path in r600_translate_colorswap()
>>
>> The only fix remaining is the change of the last if statement, in the 4
>> channels case. Originally, it contained an invalid swizzle configuration
>> that never got hit, in LE or BE. So the fix is relevant for both systems.
>>
>> This patch adds an additional 120 available visuals for LE and BE,
>> as seen in glxinfo
>
> Did you test that this doesn't cause any regressions in piglit gpu.py on
> x86? (Ideally with both r600g and radeonsi)
>
>
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer

I  tested it now with r600g (CAICOS in skylake computer) - there were
no regressions.
I didn't manage to run to completion with radeonsi (TAHITI) - without
my patches ! I didn't even try with my patches. It always got a kernel
crash somewhere during the ~8600 tests

Oded