[Mesa-dev] [PATCH 0/2] glsl: add "use of uninitialized variable" warning
Alejandro Piñeiro
apinheiro at igalia.com
Fri Feb 26 15:09:57 UTC 2016
As I reference, this week I sent a RFC series for this feature:
https://lists.freedesktop.org/archives/mesa-dev/2016-February/108442.html
This new series uses the feedback provided by Timothy Arceri (thanks!), in
order to handle the doubts I had to consider the original series as an RFC,
and handle some extra cases that were not managed by the original series.
My only doubt is that probably the name of the variable "is_lhs" is probably
not the best one, as it is used also to mark ast_expressions that are not
the lhs of an assignment.
test/all piglit run was made. No regressions.
Alejandro Piñeiro (2):
glsl: add is_lhs bool on ast_expression
glsl: raise warning when using uninitialized variables
src/compiler/glsl/ast.h | 5 +++++
src/compiler/glsl/ast_function.cpp | 3 +++
src/compiler/glsl/ast_to_hir.cpp | 37 +++++++++++++++++++++++++++++++++++++
3 files changed, 45 insertions(+)
--
2.5.0
More information about the mesa-dev
mailing list