[Mesa-dev] [PATCH] nvc0: avoid using magic numbers for the uniform_bo offsets

Samuel Pitoiset samuel.pitoiset at gmail.com
Sat Feb 27 14:12:54 UTC 2016



On 02/25/2016 12:16 AM, Ilia Mirkin wrote:
> On Wed, Feb 24, 2016 at 3:35 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> +/* TIC/TSC entries (6 user clip planes, base instance id) */
>> +#define NVC0_CB_AUX_TXC_INFO        0x000
>> +#define NVC0_CB_AUX_TXC_SIZE        (8 * 4)
>
> This makes no sense. UCP's and base instances have nothing to do with
> texture stuff. I also haven't the faintest clue what we put in there,
> or why.

Yes, and this seems to be unused... I'll investigate to make sure.

>
>    -ilia
>


More information about the mesa-dev mailing list