[Mesa-dev] [PATCH] anv: generate different VkSemaphore handles

[Jason Ekstrand]

On Sat, Feb 27, 2016 at 11:39 AM, Jacek Konieczny <jajcus at jajcus.net> wrote:

> On 2016-02-27 19:58, Jason Ekstrand wrote:
> >
> >
> > On Sat, Feb 27, 2016 at 5:47 AM, Jacek Konieczny <jajcus at jajcus.net
> > <mailto:jajcus at jajcus.net>> wrote:
> >
> >     The same handle returned by all vkCreateSemaphore() calls confuses
> >     validation layers:
> >
> >
> > From the Vulkan 1.0 spec, Glossary:
> >
> > Non-Dispatchable Handle
> >     A handle of an integer handle type. Handle values may not be unique,
> >     even for two objects of the same type.
> >
> > Semaphores are non-dispatchable handles so there is no guarantee that
> > they are unique.
>
> I have missed that.
>
> > The validation layer is broken.  Please file a bug there.
>
> Done:
> https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/49
>
> Though, I still think this check (as in validation layers), with unique
> values resturned from the driver, is a useful tool for testing Vulkan
> applications.
>

Agreed.  The check is certainly useful.  But it's the job of the validation
layer to wrap the result of vkCreateSemaphore with a unique handle and pass
that to the client application.  Then, as far as the client and validator
are concerned, they can be treated as unique even if they aren't unique to
the driver.
--Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160227/ee1f026f/attachment.html>