[Mesa-dev] [PATCH v2 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

[Marek Olšák]

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Fri, Feb 26, 2016 at 5:12 PM, Oded Gabbay <oded.gabbay at gmail.com> wrote:
> Since the rework on gallium pipe formats, there is no more need to do
> endian swap of the colorformat in the h/w, because the conversion between
> mesa format and gallium (pipe) format takes endianess into account (see
> the big #if in p_format.h).
>
> v2: return ENDIAN_NONE only for four 8-bits components
> (V_0280A0_COLOR_8_8_8_8)
>
> Signed-off-by: Oded Gabbay <oded.gabbay at gmail.com>
> Cc: "11.1 11.2" <mesa-stable at lists.freedesktop.org>
> ---
>  src/gallium/drivers/r600/r600_state_common.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_common.c
> index c3346f2..b231d1e 100644
> --- a/src/gallium/drivers/r600/r600_state_common.c
> +++ b/src/gallium/drivers/r600/r600_state_common.c
> @@ -2721,6 +2721,13 @@ uint32_t r600_colorformat_endian_swap(uint32_t colorformat)
>
>                 /* 32-bit buffers. */
>                 case V_0280A0_COLOR_8_8_8_8:
> +                       /*
> +                        * No need to do endian swaps on four 8-bits components,
> +                        * as mesa<-->pipe formats conversion take into account
> +                        * the endianess
> +                        */
> +                       return ENDIAN_NONE;
> +
>                 case V_0280A0_COLOR_2_10_10_10:
>                 case V_0280A0_COLOR_8_24:
>                 case V_0280A0_COLOR_24_8:
> --
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev