[Mesa-dev] [PATCH 04/11] nvc0: bind constant buffers for compute on Kepler

[Samuel Pitoiset]

On 02/27/2016 11:20 PM, Ilia Mirkin wrote:
> On Sat, Feb 27, 2016 at 9:02 AM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> --- a/src/gallium/drivers/nouveau/nvc0/nve4_compute.h
>> +++ b/src/gallium/drivers/nouveau/nvc0/nve4_compute.h
>> @@ -56,7 +56,7 @@ static inline void
>>   nve4_cp_launch_desc_set_cb(struct nve4_cp_launch_desc *desc,
>>                              unsigned index,
>>                              struct nouveau_bo *bo,
>> -                           uint32_t base, uint16_t size)
>> +                           uint32_t base, uint32_t size)
>
> Nope, cb's are max 64k. And I think size == 0 means 64k. Not 100% sure
> I guess. You also appear to only update the prototype and not the
> actual function (at least in this commit)

Nope, 0 means 0, and this function is static inline.

>

-- 
-Samuel