[Mesa-dev] [PATCH 13/36] i965/blorp: Get rid of brw_blorp_surface_info::array_layout

[Pohjolainen, Topi]

On Wed, Jun 29, 2016 at 05:37:32PM -0700, Jason Ekstrand wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_blorp.c | 1 -
>  src/mesa/drivers/dri/i965/brw_blorp.h | 9 ---------
>  2 files changed, 10 deletions(-)

I found only one piece of blorp even considering the layout, and that reads
it from the miptree directly:

src/mesa/drivers/dri/i965/gen6_blorp.c:      if (hiz_mt->array_layout == ALL_SLICES_AT_EACH_LOD) {

So:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

> 
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c
> index 34a16dc..d6581d0 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.c
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.c
> @@ -69,7 +69,6 @@ brw_blorp_surface_info_init(struct brw_context *brw,
>     intel_miptree_get_image_offset(mt, level, layer,
>                                    &info->x_offset, &info->y_offset);
>  
> -   info->array_layout = mt->array_layout;
>     info->swizzle = SWIZZLE_XYZW;
>  
>     if (format == MESA_FORMAT_NONE)
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h
> index dc8632b..b8a8d06 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.h
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.h
> @@ -119,15 +119,6 @@ struct brw_blorp_surface_info
>     uint32_t y_offset;
>  
>     /**
> -    * Indicates if we use the standard miptree layout (ALL_LOD_IN_EACH_SLICE),
> -    * or if we tightly pack array slices at each LOD (ALL_SLICES_AT_EACH_LOD).
> -    *
> -    * If ALL_SLICES_AT_EACH_LOD is set, then ARYSPC_LOD0 can be used. Ignored
> -    * prior to Gen7.
> -    */
> -   enum miptree_array_layout array_layout;
> -
> -   /**
>      * Format that should be used when setting up the surface state for this
>      * surface.  Should correspond to one of the BRW_SURFACEFORMAT_* enums.
>      */
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev