[Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

[Andy Furniss]

Christian König wrote:
> Am 01.07.2016 um 18:02 schrieb Andy Furniss:
>> Christian König wrote:
>>> Am 01.07.2016 um 16:42 schrieb Andy Furniss:
>>>> Boyuan Zhang wrote:
>>>>> Signed-off-by: Boyuan Zhang <boyuan.zhang at amd.com>
>>>>
>>>> Is this supposed to be the same functionally as the first version?
>>>>
>>>> I notice on Tonga that I previously got cabac, but don't now.
>>>>
>>>> I see the new options are now in radeon_vce_52.c whereas before
>>>> radeon_vce_40_2_2.c was changed - is this why?
>>>
>>> We wanted to keep the code for the old firmware versions as it is,
>>> because we otherwise would need to test them again.
>>>
>>> Because of this we moved all modifications into radeon_vce_52.c.
>>
>> Oh OK, I guess it's early days but cabac was one thing that seemed OK.
>>
>> There are many issued on Tonga using vaapi - but then I suppose
>> gstreamer and ffmpeg are not really set up for it yet.
>>
>> eg. worse first = gpu vm fault/lock with gstreamer but not ffmpeg.
>>
>> to provoke do
>>
>> gst-launch-1.0 videotestsrc ! video/x-raw, format=NV12, width=1920,
>> height=1080, framerate=60/1 ! vaapih264enc | fakesink
>>
>> then flip away/back to another desktop soon will lock.
>>
>> Maybe I am too early eg. other patches needed? or does what you say
>> above mean that vaapienc shouldn't even be enabled for older chips?
>
> Tonga should be perfectly supported, you just need recent enough firmware.
>
> What does "dmesg | grep 'Found VCE firmware Version'" give you?

Found VCE firmware Version: 50.17 Binary ID: 3