[Mesa-dev] ARB_gpu_shader_int64 second posting (softpipe/llvmpipe/radeonsi)

Dave Airlie airlied at gmail.com
Sat Jul 2 07:09:32 UTC 2016


On 30 June 2016 at 09:33, Ian Romanick <idr at freedesktop.org> wrote:
> Patches 1, 2, 3, 4 (with the changes you said you made), 6, 7, 8, 11,
> 12, and 14 through 19 are
>
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>
> I sent comments on 5 and 10.
>
> 9 was already R-b.

I've updated the ARB_gpu_shader_int64 branch in my repo with
all the tags hopefully, and it's now based on Matt's 2 strict alias patches.


>
> I'm still thinking about 13, but it's probably correct.

Let me know if you need more info.

> I'm a little surprised that nothing was needed for UBOs or SSBOs.  I
> guess the code is generic enough that, as long as glsl_type gives
> correct sizes, it just works.

I did all that work in the precursor patches pretty much, where I switch
to 64-bit checks instead of doubles.

Dave.


More information about the mesa-dev mailing list