[Mesa-dev] [PATCH 19/47] clover/llvm: Fold compile_native() call into build_module_native().

Francisco Jerez currojerez at riseup.net
Mon Jul 4 00:51:28 UTC 2016


Reviewed-by: Serge Martin <edb+mesa at sigluy.net>
---
 src/gallium/state_trackers/clover/llvm/invocation.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index 242c096..754e477 100644
--- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
+++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp
@@ -673,10 +673,10 @@ namespace {
    }
 
    module
-   build_module_native(std::vector<char> &code,
-                       llvm::Module *mod,
+   build_module_native(llvm::Module *mod, const target &target,
                        const clang::CompilerInstance &c,
                        std::string &r_log) {
+      const auto code = compile_native(mod, target, r_log);
       return build_module_common(*mod, code,
                                  get_symbol_offsets(code, r_log), c);
    }
@@ -721,11 +721,9 @@ clover::compile_program_llvm(const std::string &source,
       case PIPE_SHADER_IR_LLVM:
          m = build_module_llvm(&*mod, *c);
          break;
-      case PIPE_SHADER_IR_NATIVE: {
-         std::vector<char> code = compile_native(&*mod, target, r_log);
-         m = build_module_native(code, &*mod, *c, r_log);
+      case PIPE_SHADER_IR_NATIVE:
+         m = build_module_native(&*mod, target, *c, r_log);
          break;
-      }
    }
 
    return m;
-- 
2.9.0



More information about the mesa-dev mailing list