[Mesa-dev] [PATCH 1/4] radeon/video: fix coding style in radeon_video.c

[Christian König]

Am 07.07.2016 um 15:51 schrieb Aaron Watry:
>
>
> On Thu, Jul 7, 2016 at 4:57 AM, Christian König 
> <deathsimple at vodafone.de <mailto:deathsimple at vodafone.de>> wrote:
>
>     From: Christian König <christian.koenig at amd.com
>     <mailto:christian.koenig at amd.com>>
>
>     Signed-off-by: Christian König <christian.koenig at amd.com
>     <mailto:christian.koenig at amd.com>>
>     ---
>      src/gallium/drivers/radeon/radeon_video.c | 12 ++++++------
>      1 file changed, 6 insertions(+), 6 deletions(-)
>
>     diff --git a/src/gallium/drivers/radeon/radeon_video.c
>     b/src/gallium/drivers/radeon/radeon_video.c
>     index 5b29c78..69e4416 100644
>     --- a/src/gallium/drivers/radeon/radeon_video.c
>     +++ b/src/gallium/drivers/radeon/radeon_video.c
>     @@ -213,23 +213,23 @@ int rvid_get_video_param(struct pipe_screen
>     *screen,
>                             return codec == PIPE_VIDEO_FORMAT_MPEG4_AVC &&
>     rvce_is_fw_version_supported(rscreen);
>                     case PIPE_VIDEO_CAP_NPOT_TEXTURES:
>     -                       return 1;
>     +                       return 1;
>
>
> Did you really mean to only replace the first set of spaces with tabs 
> on these lines, or did you also mean to replace the send set?
>
> Right now, you've got 2 tabs, and then spaces for the last indentation 
> level... which seems weird.

Indeed, looks like my regular expression didn't worked as expected.

Thanks for pointing this out.

Christian.

>
> --Aaron
>
>                     case PIPE_VIDEO_CAP_MAX_WIDTH:
>                             return (rscreen->family < CHIP_TONGA) ?
>     2048 : 4096;
>                     case PIPE_VIDEO_CAP_MAX_HEIGHT:
>                             return (rscreen->family < CHIP_TONGA) ?
>     1152 : 2304;
>                     case PIPE_VIDEO_CAP_PREFERED_FORMAT:
>     -                       return PIPE_FORMAT_NV12;
>     +                       return PIPE_FORMAT_NV12;
>                     case PIPE_VIDEO_CAP_PREFERS_INTERLACED:
>     -                       return false;
>     +                       return false;
>                     case PIPE_VIDEO_CAP_SUPPORTS_INTERLACED:
>     -                       return false;
>     +                       return false;
>                     case PIPE_VIDEO_CAP_SUPPORTS_PROGRESSIVE:
>     -                       return true;
>     +                       return true;
>                     case PIPE_VIDEO_CAP_STACKED_FRAMES:
>                             return (rscreen->family < CHIP_TONGA) ? 1 : 2;
>                     default:
>     -                       return 0;
>     +                       return 0;
>                     }
>             }
>
>     --
>     2.5.0
>
>     _______________________________________________
>     mesa-dev mailing list
>     mesa-dev at lists.freedesktop.org <mailto:mesa-dev at lists.freedesktop.org>
>     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160707/4576051d/attachment.html>