[Mesa-dev] [PATCH] st/omx: fix crash when vid_enc_Constructor fails

Emil Velikov emil.l.velikov at gmail.com
Thu Jul 7 15:32:02 UTC 2016

Hi Julien,

On 7 July 2016 at 16:17, Julien Isorce <julien.isorce at gmail.com> wrote:
> It happens when trying to use omxh264enc with nouveau driver
> because it does not provide any encoder at the moment.
> It crashes on enc_ReleaseTasks(&priv->free_tasks) because
> at this time the list is not initialized.
> So this patch make sure the lists are initialized.
> Another way to fix this would be to do an early return in
> enc_ReleaseTasks if head->next is null.
IMHO your patch makes sense as-is.

Please add the stable tag before committing. and (nit) keep the
whitespace changes as separate patch.

With that, the (resulting) two patches are
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>


More information about the mesa-dev mailing list