[Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

Chad Versace chad.versace at intel.com
Thu Jul 7 18:12:19 UTC 2016


On Fri 01 Jul 2016, Chad Versace wrote:
> On Thu 30 Jun 2016, St├ęphane Marchesin wrote:
> > On Thu, Jun 30, 2016 at 3:20 PM, Gurchetan Singh
> > <gurchetansingh at chromium.org> wrote:
> > > There are a few places in the code where clearing and reading are done on
> > > incorrect buffers for GLES contexts.  See comments for details.  This
> > > fixes 75 GLES3 dEQP tests on the surfaceless platform with no regressions.
> > >
> > > v2: Corrected unclear comment
> > > v3: Make the change in context.c instead of get.c
> > > v4: Removed whitespace
> > 
> > I looked for a better way than initializing from makecurrent, but
> > there doesn't seem to be one, so...
> > 
> > Reviewed-by: <St├ęphane Marchesin marcheu at chromium.org>
> 
> This looks like a difficult problem to fix.  I also looked for a better
> way to fix the problem, but I gave up after concluding that any
> thoroughly correct fix seemed to require endless yak shaving.
> 
> If this fixes dEQP regressions, without regressing other things, then
> I approve the patch. But, I'm not convinced yet that it doesn't regress
> X11 pixmaps. I want to run some tests and step through the code with gdb
> before I give a reviewed-by.

I spent this morning trying to solve this the right way, and I gave up.
And I couldn't find any tests for X11 pixmaps that hit these codepaths.
So I pushed the patch to master.

Reviewed-by: Chad Versace <chad.versace at intel.com>





More information about the mesa-dev mailing list