[Mesa-dev] [PATCH 04/13] todo! dri: Questions about fence fd ownership
Chad Versace
chad.versace at intel.com
Sat Jul 9 00:00:54 UTC 2016
See the comments.
---
include/GL/internal/dri_interface.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h
index 99c83ec..051ddb4 100644
--- a/include/GL/internal/dri_interface.h
+++ b/include/GL/internal/dri_interface.h
@@ -418,6 +418,12 @@ struct __DRI2fenceExtensionRec {
*
* \param ctx the context associated with the fence
* \param fd the fence fd or -1
+ *
+ * TODO(chadv): Who owns the fence fd when the caller imports it (when
+ * fd != 1)? Does EGL or the driver own it?
+ *
+ * TODO(chadv): Who owns the fence fd when the driver creates it (when
+ * fd == -1)? Does EGL or the driver own it?
*/
void *(*create_fence_fd)(__DRIcontext *ctx, int fd);
@@ -430,6 +436,9 @@ struct __DRI2fenceExtensionRec {
*
* \param screen the screen associated with the fence
* \param fence the fence
+ *
+ * TODO(chadv): Should the driver return its actual fence fd? Or should it
+ * return a dup'd fd?
*/
int (*get_fence_fd)(__DRIscreen *screen, void *fence);
};
--
2.9.0.rc2
More information about the mesa-dev
mailing list