[Mesa-dev] [Mesa-stable] [PATCH] mesa: etc2 online compression is unsupported, don't attempt it

[Ilia Mirkin]

On Fri, Jul 8, 2016 at 8:16 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> On Fri, Jul 8, 2016 at 3:42 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> Cc: "11.2 12.0" <mesa-stable at lists.freedesktop.org>
>> ---
>>
>> This is sort of pending a question to KHR at
>>
>> https://www.khronos.org/bugzilla/show_bug.cgi?id=1511
>>
>> but OTOH, no matter their answer, mesa doesn't have online compression for etc2. So we should reject those calls either way.
>>
>>  src/mesa/main/teximage.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
>> index 26a6c21..81e46a1 100644
>> --- a/src/mesa/main/teximage.c
>> +++ b/src/mesa/main/teximage.c
>> @@ -1307,6 +1307,7 @@ bool
>>  _mesa_format_no_online_compression(const struct gl_context *ctx, GLenum format)
>>  {
>>     return _mesa_is_astc_format(format) ||
>> +          _mesa_is_etc2_format(format) ||
> You're missing a patch adding _mesa_is_etc2_format() helper.

Gr. Moral of the story - compile + test first. It's there for mesa
formats, but is called _mesa_format_is_etc2. There is no version for
GLenum's, I'll add it. Thanks for catching this retard-o =/

>>            compressedteximage_only_format(ctx, format);
>>  }
>>
>> --
>> 2.7.3
>>
>> _______________________________________________
>> mesa-stable mailing list
>> mesa-stable at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-stable