[Mesa-dev] [PATCH 06/14] isl: Bring back isl_format_layout::bpb

Chad Versace chad.versace at intel.com
Tue Jul 12 21:00:01 UTC 2016


On Sat 09 Jul 2016, Jason Ekstrand wrote:
> A while ago we got rid of the bits-per-block because we thought we didn't
> need it.  We're about to introduce some very useful 1 and 2-bit formats so
> we really should be able to handle them again.
> ---
>  src/intel/isl/gen_format_layout.py | 5 +++--
>  src/intel/isl/isl.h                | 2 ++
>  2 files changed, 5 insertions(+), 2 deletions(-)



> diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
> index 6ec956b..50c8e80 100644
> --- a/src/intel/isl/isl.h
> +++ b/src/intel/isl/isl.h
> @@ -639,6 +639,8 @@ struct isl_format_layout {
>     enum isl_format format;
>     const char *name;
>  
> +   uint16_t bpb; /**< bits per block */
> +
>     uint8_t bs; /**< Block size, in bytes, rounded towards 0 */
>     uint8_t bw; /**< Block width, in pixels */
>     uint8_t bh; /**< Block height, in pixels */

Small nit: There's no need for the newline there. They're all "block"
fields, after all.

Either way,
Reviewed-by: Chad Versace <chad.versace at intel.com>


More information about the mesa-dev mailing list