[Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

[Chad Versace]

On Tue 12 Jul 2016, Jason Ekstrand wrote:
> On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace <chad.versace at intel.com>
> wrote:
> 
> > I believe isl_gen7.c needs more updates:
> >
> >     static uint32_t
> >     gen7_choose_halign_el(const struct isl_device *dev,
> >                           const struct isl_surf_init_info *restrict info)
> >     {
> >    +   if (info->format == ISL_FORMAT_HIZ)
> >    +      return 2;
> >
> 
> Ugh... In an earlier version of this patch, I put the alignment directly in
> isl_chose_alignment_el.  I'm not a huge fan of repeating the alignment all
> over the place.  Thoughts?

Put it in isl_choose_alignment_el(). The updated patch in your branch
looks right to me. Still waiting on the array_spacing issue.