[Mesa-dev] [PATCH 5/5] radeonsi: report accurate SGPR and VGPR spills

[Nicolai Hähnle]

On 13.07.2016 10:45, Marek Olšák wrote:
> On Wed, Jul 13, 2016 at 10:11 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> On 12.07.2016 13:21, Marek Olšák wrote:
>>>
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> ---
>>>    src/gallium/drivers/radeonsi/si_shader.c | 18 +++++++++++++-----
>>>    src/gallium/drivers/radeonsi/si_shader.h |  2 ++
>>>    2 files changed, 15 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/src/gallium/drivers/radeonsi/si_shader.c
>>> b/src/gallium/drivers/radeonsi/si_shader.c
>>> index f60c363..31140b1 100644
>>> --- a/src/gallium/drivers/radeonsi/si_shader.c
>>> +++ b/src/gallium/drivers/radeonsi/si_shader.c
>>> @@ -5959,6 +5959,12 @@ void si_shader_binary_read_config(struct
>>> radeon_shader_binary *binary,
>>>                                  conf->scratch_bytes_per_wave =
>>>                                          G_00B860_WAVESIZE(value) * 256 *
>>> 4;
>>>                          break;
>>> +               case 0x4: /* SPILLED_SGPRS */
>>> +                       conf->spilled_sgprs = value;
>>> +                       break;
>>> +               case 0x8: /* SPILLED_VGPRS */
>>> +                       conf->spilled_vgprs = value;
>>> +                       break;
>>
>>
>> I don't see those config values. Does this require a missing change to LLVM?
>> That should go in first...
>
> Yeah, I sent the LLVM change a couple of days ago. Nobody has
> commented on it yet.

Ah, hadn't seen that. I should really figure out how to get auto-added 
to AMDGPU-related changes there. Anyway, I always add llvm-commits to 
the subscribers when I submit a review.

Cheers,
Nicolai

>
> Marek
>