[Mesa-dev] [PATCH mesa] gallium/cso: avoid unnecessary null dereference

[Marek Olšák]

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Tue, Jul 12, 2016 at 11:48 PM, Eric Engestrom <eric at engestrom.ch> wrote:
> The label `out:` calls `destroy()` which dereferences `ctx`.
> This is unnecessary as there is nothing to destroy.
> Immediately return instead.
>
> CovID: 1258255
> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> ---
>  src/gallium/auxiliary/cso_cache/cso_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c
> index b84d599..4a54cff 100644
> --- a/src/gallium/auxiliary/cso_cache/cso_context.c
> +++ b/src/gallium/auxiliary/cso_cache/cso_context.c
> @@ -251,7 +251,7 @@ struct cso_context *cso_create_context( struct pipe_context *pipe )
>  {
>     struct cso_context *ctx = CALLOC_STRUCT(cso_context);
>     if (!ctx)
> -      goto out;
> +      return NULL;
>
>     ctx->cache = cso_cache_create();
>     if (ctx->cache == NULL)
> --
> 2.9.0
>