[Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

Rob Clark robdclark at gmail.com
Wed Jul 13 16:52:24 UTC 2016


On Thu, Jun 30, 2016 at 1:16 PM, Francesco Ansanelli
<francians at gmail.com> wrote:
>

this looks like the right thing to do.. r-b for the series.  Do you
need me to push?

BR,
-R

> ---
>  src/gallium/drivers/freedreno/a2xx/fd2_screen.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c b/src/gallium/drivers/freedreno/a2xx/fd2_screen.c
> index c2baa6f..fe4849b 100644
> --- a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c
> +++ b/src/gallium/drivers/freedreno/a2xx/fd2_screen.c
> @@ -61,7 +61,7 @@ fd2_screen_is_format_supported(struct pipe_screen *pscreen,
>
>         if ((usage & (PIPE_BIND_SAMPLER_VIEW |
>                                 PIPE_BIND_VERTEX_BUFFER)) &&
> -                       (fd2_pipe2surface(format) != ~0)) {
> +                       (fd2_pipe2surface(format) != ~0u)) {
>                 retval |= usage & (PIPE_BIND_SAMPLER_VIEW |
>                                 PIPE_BIND_VERTEX_BUFFER);
>         }
> @@ -70,7 +70,7 @@ fd2_screen_is_format_supported(struct pipe_screen *pscreen,
>                                 PIPE_BIND_DISPLAY_TARGET |
>                                 PIPE_BIND_SCANOUT |
>                                 PIPE_BIND_SHARED)) &&
> -                       (fd2_pipe2color(format) != ~0)) {
> +                       (fd2_pipe2color(format) != ~0u)) {
>                 retval |= usage & (PIPE_BIND_RENDER_TARGET |
>                                 PIPE_BIND_DISPLAY_TARGET |
>                                 PIPE_BIND_SCANOUT |
> @@ -78,12 +78,12 @@ fd2_screen_is_format_supported(struct pipe_screen *pscreen,
>         }
>
>         if ((usage & PIPE_BIND_DEPTH_STENCIL) &&
> -                       (fd_pipe2depth(format) != ~0)) {
> +                       (fd_pipe2depth(format) != ~0u)) {
>                 retval |= PIPE_BIND_DEPTH_STENCIL;
>         }
>
>         if ((usage & PIPE_BIND_INDEX_BUFFER) &&
> -                       (fd_pipe2index(format) != ~0)) {
> +                       (fd_pipe2index(format) != ~0u)) {
>                 retval |= PIPE_BIND_INDEX_BUFFER;
>         }
>
> --
> 1.7.9.5
>


More information about the mesa-dev mailing list