[Mesa-dev] [PATCH 2/6] ddebug: record and dump apitrace call numbers
jon.turney at dronecode.org.uk
Wed Jul 13 16:44:52 UTC 2016
On 05/07/2016 11:17, Marek Olšák wrote:
> On Tue, Jul 5, 2016 at 12:13 PM, Jon Turney wrote:
>> On 01/07/2016 00:21, Marek Olšák wrote:
>> This adds a use of alloca(), without a corresponding #include <alloca.h>
>> This fails to build, for me:
>>> In file included from dd_pipe.h:34:0,
>>> from dd_screen.c:28:
>>> dd_util.h: In function 'dd_parse_apitrace_marker':
>>> dd_util.h:84:4: error: implicit declaration of function 'alloca'
>>> s = alloca(len + 1);
>> Perhaps the attached is needed?
> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Actually, I guess this should use c99_alloca.h, since that seems to be
the mechanism for doing this portably.
Pushed with that correction.
More information about the mesa-dev