[Mesa-dev] [PATCH] Revert "gallium: Force blend color to 16-byte alignment"
nhaehnle at gmail.com
Thu Jul 14 14:02:41 UTC 2016
Thanks! In addition to Emil's suggestion, please be sure to definitely
reference the bugreport in the commit message:
With that fixed, the patch is
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
On 13.07.2016 17:39, Tim Rowley wrote:
> This reverts commit d8d6091a846ac2a40a011d512d6d57f6c8442e6a.
> Cc: <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Tim Rowley <timothy.o.rowley at intel.com>
> src/gallium/include/pipe/p_state.h | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
> diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h
> index a73a771..a3ae870 100644
> --- a/src/gallium/include/pipe/p_state.h
> +++ b/src/gallium/include/pipe/p_state.h
> @@ -326,17 +326,7 @@ struct pipe_blend_state
> struct pipe_blend_color
> - /**
> - * Making the color array explicitly 16-byte aligned provides a hint to
> - * compilers to make more efficient auto-vectorization optimizations.
> - * The actual performance gains from vectorizing the blend color array are
> - * fairly minimal, if any, but the alignment is necessary to work around
> - * buggy vectorization in some compilers which fail to generate the correct
> - * unaligned accessors resulting in a segfault. Specifically several
> - * versions of the Intel compiler are known to be affected but it's likely
> - * others are as well.
> - */
> - PIPE_ALIGN_VAR(16) float color;
> + float color;
More information about the mesa-dev