[Mesa-dev] [PATCH] mesa/st: reduce size of state->st bitmask

[Rob Clark]

On Thu, Jul 14, 2016 at 4:41 PM, Gustaw Smolarczyk <wielkiegie at gmail.com> wrote:
> 2016-07-14 22:14 GMT+02:00 Rob Clark <robdclark at gmail.com>:
>> In d035d50 this changed to 64b.. which I'm pretty sure was
>> unintentional.  Revert it back to 32b so the entire state struct
>> is a nice round 64b (cache-line size).
> Actually, cache line size, at least on most x86 and ARM processors, is
> 64B (bytes) not 64b (bits).

oh, yeah, right.. a bit of a think-o

(all the same, I think this need only be 32b)

BR,
-R


> Regards,
> Gustaw
>>
>> (Note sure that it would actually be measurable, but I did notice
>> that check_state() was hot in some benchmarks.)
>>
>> Signed-off-by: Rob Clark <robdclark at gmail.com>
>> ---
>>  src/mesa/state_tracker/st_context.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/state_tracker/st_context.h b/src/mesa/state_tracker/st_context.h
>> index cc25e06..18394eb 100644
>> --- a/src/mesa/state_tracker/st_context.h
>> +++ b/src/mesa/state_tracker/st_context.h
>> @@ -70,7 +70,7 @@ struct u_upload_mgr;
>>
>>  struct st_state_flags {
>>     GLbitfield mesa;  /**< Mask of _NEW_x flags */
>> -   uint64_t st;      /**< Mask of ST_NEW_x flags */
>> +   uint32_t st;      /**< Mask of ST_NEW_x flags */
>>  };
>>
>>  struct st_tracked_state {
>> --
>> 2.7.4
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev