[Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

[Francisco Jerez]

Vedran Miletić <vedran at miletic.net> writes:

> On 07/13/2016 12:49 AM, Francisco Jerez wrote:
>> You can just replace the current implementation of tokenize(), it's not
>> used for anything else other than splitting compiler arguments AFAIK.
>>
>
> Done, patch incoming.
>
>>> Also, I would really like to progress on getting this merged in some
>>> way, so any general feedback is also welcome.
>>>
>>
>> You've got some more feedback in my previous reply it doesn't look like
>> you've taken into account yet, it would be nice to see those addressed
>> before we get your patch merged.
>>
>
> Indeed. Is [1] what you had in mind?
>

I was referring to the other code suggestions I pointed out in this message:

https://lists.freedesktop.org/archives/mesa-dev/2016-June/119419.html

Thanks a lot though for filing a Khronos bug report for this.

> Regards,
> Vedran
>
> [1] https://www.khronos.org/bugzilla/show_bug.cgi?id=1514
>
> -- 
> Vedran Miletić
> vedran.miletic.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160714/bd553d61/attachment-0001.sig>