[Mesa-dev] [PATCH 04/10] egl/android: Stop leaking DRI images

Eric Anholt eric at anholt.net
Fri Jul 15 18:05:16 UTC 2016


Tomasz Figa <tfiga at chromium.org> writes:

> Current implementation of the DRI image loader does not free the images
> created in get_back_bo() and so leaks memory. Moreover, it creates a new
> image every time the DRI driver queries for buffers, even if the backing
> native buffer has not changed. leaking memory again.
>
> This patch adds missing call to destroyImage() in droid_enqueue_buffer()
> and a check if image is already created to get_back_bo() to fix the
> above.

This patch is:

Reviewed-by: Eric Anholt <eric at anholt.net>

But I noticed in review, it looks like droid_destroy_surface() could
also use an image destroy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160715/51ce063f/attachment.sig>


More information about the mesa-dev mailing list