[Mesa-dev] [PATCH 1/4] i965: Drop VARYING_SLOT_FACE special case in barycentric setup.

Kenneth Graunke kenneth at whitecape.org
Sat Jul 16 06:43:12 UTC 2016


glsl_to_nir always produces a system value for gl_FrontFacing, rather
than an input.  So there should never be an input with this slot,
making this code dead.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_fs.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index c907725..446cf3a 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -6341,9 +6341,8 @@ brw_compute_barycentric_interp_modes(const struct brw_device_info *devinfo,
    unsigned barycentric_interp_modes = 0;
 
    nir_foreach_variable(var, &shader->inputs) {
-      /* Ignore WPOS and FACE, because they don't require interpolation. */
-      if (var->data.location == VARYING_SLOT_POS ||
-          var->data.location == VARYING_SLOT_FACE)
+      /* Ignore WPOS; it doesn't require interpolation. */
+      if (var->data.location == VARYING_SLOT_POS)
          continue;
 
       /* Flat inputs don't need barycentric modes. */
-- 
2.9.0



More information about the mesa-dev mailing list