[Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

Emil Velikov emil.l.velikov at gmail.com
Mon Jul 18 14:12:58 UTC 2016


On 18 July 2016 at 14:11, Marek Olšák <maraeo at gmail.com> wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> The goal is to do this in st_validate_state:
>    while (dirty)
>       atoms[u_bit_scan(&dirty)]->update(st);
>
> That implies that atoms can't specify which flags they consume.
> There is exactly one ST_NEW_* flag for each atom. (58 flags in total)
>
> There are macros that combine multiple flags into one for easier use.
>
> All _NEW_* flags are translated into ST_NEW_* flags in st_invalidate_state.
> st/mesa doesn't keep the _NEW_* flags after that.
>
> torcs is 2% faster between the previous patch and the end of this series.
Hell yea, -300 diff stat, 2% improvement and easier to follow code
(from a quick skim) :-)

>  create mode 100644 src/mesa/state_tracker/st_atom_list.h

Please add this to the STATETRACKER_FILES list in src/mesa/Makefile.sources.

Thanks
Emil


More information about the mesa-dev mailing list