[Mesa-dev] [PATCH 4/9] st/mesa: skip updates of states that have no effect

Marek Olšák maraeo at gmail.com
Mon Jul 18 14:44:10 UTC 2016


On Mon, Jul 18, 2016 at 3:31 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Mon, Jul 18, 2016 at 9:11 AM, Marek Olšák <maraeo at gmail.com> wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> ---
>>  src/mesa/state_tracker/st_atom.c | 15 ++++++++++++++-
>>  src/mesa/state_tracker/st_atom.h | 22 ++++++++++++++--------
>>  2 files changed, 28 insertions(+), 9 deletions(-)
>>
>> diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c
>> index 5843d2a..77f1ec3 100644
>> --- a/src/mesa/state_tracker/st_atom.c
>> +++ b/src/mesa/state_tracker/st_atom.c
>> @@ -107,6 +107,7 @@ static void check_attrib_edgeflag(struct st_context *st)
>>
>>  void st_validate_state( struct st_context *st, enum st_pipeline pipeline )
>>  {
>> +   struct gl_context *ctx = st->ctx;
>>     uint64_t dirty, pipeline_mask;
>>     uint32_t dirty_lo, dirty_hi;
>>
>> @@ -117,11 +118,23 @@ void st_validate_state( struct st_context *st, enum st_pipeline pipeline )
>>     /* Get pipeline state. */
>>     switch (pipeline) {
>>     case ST_PIPELINE_RENDER:
>> -      check_attrib_edgeflag(st);
>> +      if (st->ctx->API != API_OPENGL_CORE)
>
> I think that should be == API_OPENGL_COMPAT. Pretty sure ES doesn't
> have it either.

Thanks. Fixed locally.

Marek


More information about the mesa-dev mailing list