[Mesa-dev] [PATCH 0/9] st/mesa state tracking rewrite

Nicolai Hähnle nhaehnle at gmail.com
Tue Jul 19 14:49:56 UTC 2016


On 18.07.2016 15:11, Marek Olšák wrote:
> This series rewrites state tracking in st/mesa. The advantages of the new
> approach are described in the main patch. Here I'll just say it that it was
> motivated by a little inefficient code in st_validate_state and the mapping
> of _NEW_* flags to atoms. The new approach works with one ST_NEW_* flag per
> atom and those are the only flags that are available to st/mesa.
> The _NEW_* flags are translated by Driver.UpdateState to ST_NEW_* flags
> and then forgotten, so st/mesa doesn't use them internally.

Very nice, the design is much cleaner now. By its nature the main patch 
is hard to follow, but assuming you've thoroughly tested this for 
regressions at least with Piglit, ideally also dEQP or the CTS:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

>
> Please review.
>
> Marek
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>


More information about the mesa-dev mailing list