[Mesa-dev] [PATCH 2/2] gm107/ir: make use of ADD32I for all immediates

[Samuel Pitoiset]

On 07/19/2016 05:56 PM, Ilia Mirkin wrote:
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
> Please put together some shader tests for this, and verify that this
> fix is not necessary on earlier SM versions.

Okay, will do.

>
> On Tue, Jul 19, 2016 at 8:47 AM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> ADD only allows to emit 19-bits immediates.
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> Cc: <mesa-stable at lists.freedesktop.org>
>> ---
>>  src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp
>> index 5ae1898..6904eba 100644
>> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp
>> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp
>> @@ -1682,7 +1682,7 @@ CodeEmitterGM107::emitNOT()
>>  void
>>  CodeEmitterGM107::emitIADD()
>>  {
>> -   if (!longIMMD(insn->src(1))) {
>> +   if (insn->src(1).getFile() != FILE_IMMEDIATE) {
>>        switch (insn->src(1).getFile()) {
>>        case FILE_GPR:
>>           emitInsn(0x5c100000);
>> --
>> 2.8.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev