[Mesa-dev] [PATCH RFC 5/8] gm107/ir: add emission for SUSTx and SULDx

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Jul 19 17:30:11 UTC 2016



On 07/19/2016 07:14 PM, Józef Kucia wrote:
> On Mon, Jul 18, 2016 at 10:55 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> +   } else if (insn->tex.target == TEX_TARGET_2D_ARRAY ||
>> +              insn->tex.target == TEX_TARGET_CUBE ||
>> +              insn->tex.target == TEX_TARGET_CUBE_ARRAY) {
>> +      target = 8;
>> +   } else if (insn->tex.target == TEX_TARGET_3D ||
>> +              insn->tex.target == TEX_TARGET_CUBE_ARRAY) {
>> +      target = 10;
>
> TEX_TARGET_CUBE_ARRAY is listed twice. Apart from that a switch
> statement might be more readable.

Good catch, thanks!

>


More information about the mesa-dev mailing list