[Mesa-dev] [PATCH 7/7] i965: Delete the FS_OPCODE_INTERPOLATE_AT_CENTROID virtual opcode.

[Jason Ekstrand]

Patches 2, 3, 4, and 7 are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

I've left comments on a few others.

On Mon, Jul 18, 2016 at 10:30 PM, Jason Ekstrand <jason at jlekstrand.net>
wrote:

> On Jul 18, 2016 10:11 PM, "Chris Forbes" <chrisf at ijw.co.nz> wrote:
> >
> > I remember arguing about this when it got added -- tradeoff was payload
> size/register pressure vs needing to call out to this unit, if centroid
> barycentric coords weren't required for anything else? It does seem fairly
> pointless, though.
> >
> > For the series:-
> >
> > Reviewed-by: Chris Forbes <chrisforbes at google.com>
>
> I'd like to chip in before you get too excited and push. I'll take a
> proper look tomorrow.
>
> > On Tue, Jul 19, 2016 at 8:26 AM, Kenneth Graunke <kenneth at whitecape.org>
> wrote:
> >>
> >> We no longer use this message.  As far as I can tell, it's fairly
> >> useless - the equivalent information is provided in the payload.
> >>
> >> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> >> ---
> >>  src/mesa/drivers/dri/i965/brw_defines.h        | 1 -
> >>  src/mesa/drivers/dri/i965/brw_fs.cpp           | 2 --
> >>  src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 5 -----
> >>  src/mesa/drivers/dri/i965/brw_shader.cpp       | 2 --
> >>  4 files changed, 10 deletions(-)
> >>
> >> diff --git a/src/mesa/drivers/dri/i965/brw_defines.h
> b/src/mesa/drivers/dri/i965/brw_defines.h
> >> index b5a259e..2814fa7 100644
> >> --- a/src/mesa/drivers/dri/i965/brw_defines.h
> >> +++ b/src/mesa/drivers/dri/i965/brw_defines.h
> >> @@ -1120,7 +1120,6 @@ enum opcode {
> >>     FS_OPCODE_UNPACK_HALF_2x16_SPLIT_X,
> >>     FS_OPCODE_UNPACK_HALF_2x16_SPLIT_Y,
> >>     FS_OPCODE_PLACEHOLDER_HALT,
> >> -   FS_OPCODE_INTERPOLATE_AT_CENTROID,
> >>     FS_OPCODE_INTERPOLATE_AT_SAMPLE,
> >>     FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET,
> >>     FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET,
> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
> b/src/mesa/drivers/dri/i965/brw_fs.cpp
> >> index 06007fe..120d6dd 100644
> >> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> >> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> >> @@ -250,7 +250,6 @@ fs_inst::is_send_from_grf() const
> >>     switch (opcode) {
> >>     case FS_OPCODE_VARYING_PULL_CONSTANT_LOAD_GEN7:
> >>     case SHADER_OPCODE_SHADER_TIME_ADD:
> >> -   case FS_OPCODE_INTERPOLATE_AT_CENTROID:
> >>     case FS_OPCODE_INTERPOLATE_AT_SAMPLE:
> >>     case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:
> >>     case FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET:
> >> @@ -4785,7 +4784,6 @@ get_lowered_simd_width(const struct
> brw_device_info *devinfo,
> >>     case FS_OPCODE_PACK_HALF_2x16_SPLIT:
> >>     case FS_OPCODE_UNPACK_HALF_2x16_SPLIT_X:
> >>     case FS_OPCODE_UNPACK_HALF_2x16_SPLIT_Y:
> >> -   case FS_OPCODE_INTERPOLATE_AT_CENTROID:
> >>     case FS_OPCODE_INTERPOLATE_AT_SAMPLE:
> >>     case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:
> >>     case FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET:
> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> >> index 1e9c7da..a390184 100644
> >> --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> >> +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> >> @@ -2054,11 +2054,6 @@ fs_generator::generate_code(const cfg_t *cfg,
> int dispatch_width)
> >>           }
> >>           break;
> >>
> >> -      case FS_OPCODE_INTERPOLATE_AT_CENTROID:
> >> -         generate_pixel_interpolator_query(inst, dst, src[0], src[1],
> >> -
>  GEN7_PIXEL_INTERPOLATOR_LOC_CENTROID);
> >> -         break;
> >> -
> >>        case FS_OPCODE_INTERPOLATE_AT_SAMPLE:
> >>           generate_pixel_interpolator_query(inst, dst, src[0], src[1],
> >>
> GEN7_PIXEL_INTERPOLATOR_LOC_SAMPLE);
> >> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp
> b/src/mesa/drivers/dri/i965/brw_shader.cpp
> >> index f3b5487..559e44c 100644
> >> --- a/src/mesa/drivers/dri/i965/brw_shader.cpp
> >> +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
> >> @@ -367,8 +367,6 @@ brw_instruction_name(const struct brw_device_info
> *devinfo, enum opcode op)
> >>     case FS_OPCODE_PLACEHOLDER_HALT:
> >>        return "placeholder_halt";
> >>
> >> -   case FS_OPCODE_INTERPOLATE_AT_CENTROID:
> >> -      return "interp_centroid";
> >>     case FS_OPCODE_INTERPOLATE_AT_SAMPLE:
> >>        return "interp_sample";
> >>     case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:
> >> --
> >> 2.9.0
> >>
> >> _______________________________________________
> >> mesa-dev mailing list
> >> mesa-dev at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
> >
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160719/a124efd4/attachment.html>