[Mesa-dev] [PATCH 2/7] nir: Add a nir_lower_io flag for using load_interpolated_input intrins.

Kenneth Graunke kenneth at whitecape.org
Wed Jul 20 00:05:09 UTC 2016

On Tuesday, July 19, 2016 12:57:23 PM PDT Jason Ekstrand wrote:
> On Mon, Jul 18, 2016 at 10:00 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
> > Seems a little unfortunate to add a random bool to this interface which is
> > otherwise fairly descriptive, but OK.
> >
> I agree that this is a bit unfortunate.  I was going to suggest adding a
> flags parameter and a bitfield union but a flags parameter for a single
> bool is also kind-of stupid.  I vote we keep it as-is and make it a flags
> parameter once we have 2 bools.
> --Jason

I agree, this sucks.  I've dropped this patch locally in favor of adding
a nir_shader_compiler_options::use_interpolated_input_intrinsics flag
(which I just folded into patch 3 as it's a tiny amount of code).

That was really easy to hook up and is a lot cleaner.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160719/34218789/attachment.sig>

More information about the mesa-dev mailing list