[Mesa-dev] [PATCH 1/2] clover: Add missing include v2

Francisco Jerez currojerez at riseup.net
Wed Jul 20 18:47:47 UTC 2016


Tom Stellard <thomas.stellard at amd.com> writes:

> There was a patch committed to clang to remove unnecessary includes from
> header files, so we now need to explicitly include
> clang/Lex/PreprocessorOptions.h
>
> v2:
>   - Use <> instead of "" for the include path.
> ---
>  src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> index 4b7de26..bbd66d4 100644
> --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> @@ -39,6 +39,8 @@
>  #include <llvm-c/Target.h>
>  
>  #include <clang/CodeGen/CodeGenAction.h>
> +#include <clang/Lex/PreprocessorOptions.h>
> +

Redundant whitespace, with that removed:

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

>  #include <clang/Frontend/TextDiagnosticBuffer.h>
>  #include <clang/Frontend/TextDiagnosticPrinter.h>
>  #include <clang/Basic/TargetInfo.h>
> -- 
> 2.7.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160720/a4bd4693/attachment.sig>


More information about the mesa-dev mailing list