[Mesa-dev] [PATCH 00/16] Various Vulkan/SPIR-V fixes (mostly SPIR-V)

Kenneth Graunke kenneth at whitecape.org
Fri Jul 22 22:04:37 UTC 2016


On Thursday, July 21, 2016 9:21:39 PM PDT Jason Ekstrand wrote:
> I pulled the latest version of the Vulkan CTS and gave it a run.  One of
> the major aditions was a pile of tests for different texturing operations.
> This demonstrated that our texturing support was, well, sub-par.  These
> patches get it most of the way fixed up.  As a nice side-benifit, it also
> fixes 5 piglit tests on GL.
> 
> Jason Ekstrand (16):
>   spirv/nir: Fix some texture opcode asserts
>   spirv/nir: Add support for shadow samplers that return vec4
>   spirv/nir: Properly handle gather components
>   anv/pipeline: Set binding_table.gather_texture_start
>   nir: Add a helper for determining the type of a texture source
>   nir/lower_tex: Add some helpers for working with tex sources
>   nir/lower_tex: Add support for lowering coordinate offsets
>   i965/nir: Enable NIR lowering of txf and rect offsets
>   i965: Get rid of the do_lower_unnormalized_offsets pass
>   spirv/nir: Don't increment coord_components for array lod queries
>   anv/image: Assert that the image format is actually supported
>   spirv/nir/: Move opcode selection higher up in handle_texture
>   spirv/nir: Refactor type handling in handle_texture
>   nir/spirv: Refactor coordinate handling in handle_texture
>   spirv/nir: Handle texture projectors
>   spirv/nir: Add support for ImageQuerySamples
> 
>  src/compiler/nir/nir.h                             |  54 ++++++
>  src/compiler/nir/nir_lower_tex.c                   |  98 +++++++++--
>  src/compiler/spirv/spirv_to_nir.c                  | 189 ++++++++++++---------
>  src/intel/vulkan/anv_image.c                       |   7 +-
>  src/intel/vulkan/anv_pipeline.c                    |   1 +
>  src/mesa/drivers/dri/i965/Makefile.sources         |   1 -
>  src/mesa/drivers/dri/i965/brw_context.h            |   1 -
>  src/mesa/drivers/dri/i965/brw_link.cpp             |   1 -
>  .../dri/i965/brw_lower_unnormalized_offset.cpp     | 106 ------------
>  src/mesa/drivers/dri/i965/brw_nir.c                |   2 +
>  10 files changed, 255 insertions(+), 205 deletions(-)
>  delete mode 100644 src/mesa/drivers/dri/i965/brw_lower_unnormalized_offset.cpp

Patch 15 has a "projetor" typo in a comment, and patch 12 has a bonus /
in the commit title.  Other than that, series is:

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160722/b0040ec6/attachment.sig>


More information about the mesa-dev mailing list