[Mesa-dev] [PATCH 11/15] ddebug: don't save pointers to call parameters

Marek Olšák maraeo at gmail.com
Sat Jul 23 00:14:34 UTC 2016


From: Marek Olšák <marek.olsak at amd.com>

---
 src/gallium/drivers/ddebug/dd_draw.c | 8 ++++----
 src/gallium/drivers/ddebug/dd_pipe.h | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c
index 86d6102..836f812 100644
--- a/src/gallium/drivers/ddebug/dd_draw.c
+++ b/src/gallium/drivers/ddebug/dd_draw.c
@@ -357,7 +357,7 @@ dd_dump_resource_copy_region(struct dd_draw_state *dstate,
    DUMP_M(uint, info, dstz);
    DUMP_M(resource, info, src);
    DUMP_M(uint, info, src_level);
-   DUMP_M(box, info, src_box);
+   DUMP_M_ADDR(box, info, src_box);
 }
 
 static void
@@ -404,7 +404,7 @@ dd_dump_clear(struct dd_draw_state *dstate, struct call_clear *info, FILE *f)
 {
    fprintf(f, "%s:\n", __func__+8);
    DUMP_M(uint, info, buffers);
-   DUMP_M(color_union, info, color);
+   DUMP_M_ADDR(color_union, info, color);
    DUMP_M(double, info, depth);
    DUMP_M(hex, info, stencil);
 }
@@ -700,7 +700,7 @@ dd_context_resource_copy_region(struct pipe_context *_pipe,
    call.info.resource_copy_region.dstz = dstz;
    call.info.resource_copy_region.src = src;
    call.info.resource_copy_region.src_level = src_level;
-   call.info.resource_copy_region.src_box = src_box;
+   call.info.resource_copy_region.src_box = *src_box;
 
    dd_before_draw(dctx);
    pipe->resource_copy_region(pipe,
@@ -780,7 +780,7 @@ dd_context_clear(struct pipe_context *_pipe, unsigned buffers,
 
    call.type = CALL_CLEAR;
    call.info.clear.buffers = buffers;
-   call.info.clear.color = color;
+   call.info.clear.color = *color;
    call.info.clear.depth = depth;
    call.info.clear.stencil = stencil;
 
diff --git a/src/gallium/drivers/ddebug/dd_pipe.h b/src/gallium/drivers/ddebug/dd_pipe.h
index e4960d5..5ba1b7a 100644
--- a/src/gallium/drivers/ddebug/dd_pipe.h
+++ b/src/gallium/drivers/ddebug/dd_pipe.h
@@ -72,13 +72,13 @@ struct call_resource_copy_region
    unsigned dstx, dsty, dstz;
    struct pipe_resource *src;
    unsigned src_level;
-   const struct pipe_box *src_box;
+   struct pipe_box src_box;
 };
 
 struct call_clear
 {
    unsigned buffers;
-   const union pipe_color_union *color;
+   union pipe_color_union color;
    double depth;
    unsigned stencil;
 };
-- 
2.7.4



More information about the mesa-dev mailing list