[Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

[Andy Furniss]

Nayan Deshmukh wrote:
> Hi Christian,
>
> I have sent the new patches, they should fix all the artifacts. :)

I have briefly tried these over time and v3 1/2 + v2 2/2 still show
artifacts for me.

All versions have issues with 8/9, and I agree with the view that
you shouldn't really use up all the levels anyway.

For me level 8/9 render nothing and on quit will segfault/abort
this one is mpv -

Exiting... (Quit)
[Thread 0x7fffeccde700 (LWP 25133) exited]
[Thread 0x7fffed4df700 (LWP 25132) exited]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffe6ffd700 (LWP 25137)]
pipe_reference_described (get_desc=<optimized out>, reference=0x0, 
ptr=0x700000001) at ../../../../src/gallium/auxiliary/util/u_inlines.h:89
89               if (p_atomic_dec_zero(&ptr->count)) {
(gdb) bt
#0  pipe_reference_described (get_desc=<optimized out>, reference=0x0, 
ptr=0x700000001) at ../../../../src/gallium/auxiliary/util/u_inlines.h:89
#1  pipe_resource_reference (tex=0x0, ptr=0x7fffdc31ced0) at 
../../../../src/gallium/auxiliary/util/u_inlines.h:138
#2  r600_resource_reference (res=0x0, ptr=0x7fffdc31ced0) at 
../../../../src/gallium/drivers/radeon/r600_pipe_common.h:801
#3  si_pm4_free_state_simple (state=0x7fffdc31ced0) at si_pm4.c:110
#4  0x00007fffe5adfc24 in vl_lanczos_filter_cleanup 
(filter=0x7fffdc367310) at vl/vl_lanczos_filter.c:353
#5  0x00007fffe5a9fb0e in vlVdpVideoMixerDestroy (mixer=10) at mixer.c:216
#6  0x000000000051628e in mp_vdpau_mixer_destroy (mixer=0x7fffdc30bf50) 
at ../video/vdpau_mixer.c:83
#7  0x00000000005414a4 in uninit (vo=0x2273570) at 
../video/out/vo_vdpau.c:1034
#8  0x000000000053b5b1 in vo_thread (ptr=0x2273570) at ../video/out/vo.c:941
#9  0x00007ffff5a03434 in start_thread () from /lib/libpthread.so.0
#10 0x00007ffff0fce06d in clone () from /lib/libc.so.6

and mplayer -

*** Error in `/mnt/sdb1/Gits/mplayer/mplayer': free(): invalid pointer: 
0x0000555557328310 ***
======= Backtrace: =========
/lib/libc.so.6(+0x72025)[0x7ffff0773025]
/lib/libc.so.6(+0x77986)[0x7ffff0778986]
/lib/libc.so.6(+0x7816e)[0x7ffff077916e]
/usr/lib/vdpau/libvdpau_radeonsi.so.1(+0x5fc24)[0x7fffea725c24]
/usr/lib/vdpau/libvdpau_radeonsi.so.1(+0x1fb0e)[0x7fffea6e5b0e]
/mnt/sdb1/Gits/mplayer/mplayer(+0x18dd51)[0x5555556e1d51]
======= Memory map: ========

<snip>

Program received signal SIGABRT, Aborted.
0x00007ffff07345c8 in raise () from /lib/libc.so.6
(gdb) bt
#0  0x00007ffff07345c8 in raise () from /lib/libc.so.6
#1  0x00007ffff0735a4a in abort () from /lib/libc.so.6
#2  0x00007ffff077302a in __libc_message () from /lib/libc.so.6
#3  0x00007ffff0778986 in malloc_printerr () from /lib/libc.so.6
#4  0x00007ffff077916e in _int_free () from /lib/libc.so.6
#5  0x00007fffea725c24 in vl_lanczos_filter_cleanup 
(filter=0x555557264f80) at vl/vl_lanczos_filter.c:353
#6  0x00007fffea6e5b0e in vlVdpVideoMixerDestroy (mixer=4) at mixer.c:216
#7  0x00005555556e1d51 in free_video_specific ()
#8  0x0000000000000001 in ?? ()
#9  0x0000000000000000 in ?? ()